Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): remove omitempty tags to get complete representation of AnalysisResult #2078

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

bacherfl
Copy link
Member

Closes #2045

…ntation of AnalysisResult

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 3fc1425
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64fefd2eab12380008fed781
😎 Deploy Preview https://deploy-preview-2078--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #2078 (3117629) into main (9a98e97) will increase coverage by 0.06%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2078      +/-   ##
==========================================
+ Coverage   83.98%   84.04%   +0.06%     
==========================================
  Files         150      150              
  Lines        9597     9597              
==========================================
+ Hits         8060     8066       +6     
+ Misses       1246     1242       -4     
+ Partials      291      289       -2     
Files Changed Coverage Δ
...perator/controllers/common/analysis/types/types.go 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.89% <ø> (+0.41%) ⬆️
lifecycle-operator 84.94% <ø> (ø)
metrics-operator 85.43% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl marked this pull request as ready for review September 11, 2023 13:13
@bacherfl bacherfl requested a review from a team as a code owner September 11, 2023 13:13
@bacherfl bacherfl merged commit a08b9ca into keptn:main Sep 14, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnalysisResult: Remove omitempty tags from properties
3 participants