Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): add query to the analysis result #2188

Merged
merged 2 commits into from
Sep 28, 2023
Merged

feat(metrics-operator): add query to the analysis result #2188

merged 2 commits into from
Sep 28, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Sep 27, 2023

Changes

  • introduce query to the detailed raw analysis result in Analysis CR
  • unit tests
  • integration tests

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation metrics-operator helm labels Sep 27, 2023
@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 1d3ca19
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/651415548f71b00008117722
😎 Deploy Preview https://deploy-preview-2188--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2188 (2dd6cd7) into main (34e5384) will increase coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2188      +/-   ##
==========================================
+ Coverage   84.60%   84.64%   +0.03%     
==========================================
  Files         153      153              
  Lines        9881     9883       +2     
==========================================
+ Hits         8360     8365       +5     
+ Misses       1234     1232       -2     
+ Partials      287      286       -1     
Files Coverage Δ
metrics-operator/api/v1alpha3/analysis_types.go 100.00% <ø> (ø)
...rator/controllers/analysis/objectives_evaluator.go 78.26% <100.00%> (+0.98%) ⬆️
...controllers/common/analysis/objective_evaluator.go 100.00% <100.00%> (+6.66%) ⬆️
...perator/controllers/common/analysis/types/types.go 100.00% <ø> (ø)
Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 58.65% <ø> (+0.20%) ⬆️
lifecycle-operator 85.02% <ø> (ø)
metrics-operator 87.73% <100.00%> (+0.11%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT marked this pull request as ready for review September 27, 2023 13:48
@odubajDT odubajDT requested review from a team as code owners September 27, 2023 13:48
Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, this will be very helpful for troubleshooting analyses

@odubajDT odubajDT merged commit 233aac4 into keptn:main Sep 28, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm metrics-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants