Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): add helm chart for metrics operator #2189

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Sep 27, 2023

closes #2181

@RealAnna RealAnna requested a review from a team as a code owner September 27, 2023 14:02
@github-actions github-actions bot added documentation Improvements or additions to documentation metrics-operator helm labels Sep 27, 2023
@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 63b7503
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6516936c294aa800087e6003
😎 Deploy Preview https://deploy-preview-2189--keptn-lifecycle-toolkit.netlify.app/docs/implementing/evaluations
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2189 (410798b) into main (b3b68fa) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2189   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files         154      154           
  Lines        9918     9918           
=======================================
  Hits         8382     8382           
  Misses       1249     1249           
  Partials      287      287           
Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 57.82% <ø> (ø)
lifecycle-operator 85.02% <ø> (ø)
metrics-operator 87.38% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna marked this pull request as draft September 27, 2023 14:05
@github-actions github-actions bot added the ops label Sep 27, 2023
@RealAnna RealAnna force-pushed the feat/2181/umbrella_metrics_operator branch from 03d89e7 to 82d4feb Compare September 28, 2023 06:26
@RealAnna RealAnna marked this pull request as ready for review September 28, 2023 06:45
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe also release-please conf needs to be updated to track the value file

@RealAnna
Copy link
Contributor Author

I believe also release-please conf needs to be updated to track the value file

we discussed having all pipeline changes done in a single ticket, @thisthat do you think that is not a good idea? 🤔

@thisthat
Copy link
Member

I believe also release-please conf needs to be updated to track the value file

we discussed having all pipeline changes done in a single ticket, @thisthat do you think that is not a good idea? 🤔

sorry, I miss that discussion. I am fine doing that in a single PR :)

metrics-operator/chart/Chart.yaml Outdated Show resolved Hide resolved
metrics-operator/chart/Chart.yaml Outdated Show resolved Hide resolved
metrics-operator/chart/values.yaml Outdated Show resolved Hide resolved
.github/scripts/.helm-tests/default/result.yaml Outdated Show resolved Hide resolved
metrics-operator/chart/Chart.yaml Outdated Show resolved Hide resolved
metrics-operator/chart/Chart.yaml Outdated Show resolved Hide resolved
metrics-operator/chart/Chart.yaml Outdated Show resolved Hide resolved
metrics-operator/chart/README.md Outdated Show resolved Hide resolved
metrics-operator/chart/templates/deployment.yaml Outdated Show resolved Hide resolved
metrics-operator/chart/templates/deployment.yaml Outdated Show resolved Hide resolved
metrics-operator/chart/templates/deployment.yaml Outdated Show resolved Hide resolved
metrics-operator/chart/values.yaml Outdated Show resolved Hide resolved
@RealAnna RealAnna force-pushed the feat/2181/umbrella_metrics_operator branch 2 times, most recently from 91e4230 to a0ba7ad Compare September 28, 2023 13:25
odubajDT
odubajDT previously approved these changes Sep 28, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com>

removed empty line

Signed-off-by: realanna <anna.reale@dynatrace.com>

removed empty line

Signed-off-by: realanna <anna.reale@dynatrace.com>

removed empty line

Signed-off-by: realanna <anna.reale@dynatrace.com>

removed empty line

Signed-off-by: realanna <anna.reale@dynatrace.com>

removed empty line

Signed-off-by: realanna <anna.reale@dynatrace.com>

removed empty line

Signed-off-by: realanna <anna.reale@dynatrace.com>

adds  app.kubernetes.io/component: metrics-operator

Signed-off-by: realanna <anna.reale@dynatrace.com>

fix: missing default container

Signed-off-by: realanna <anna.reale@dynatrace.com>

Update metrics-operator/config/default/manager_config_patch.yaml

Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update metrics-operator/config/manager/kustomization.yaml

Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

feat: rename label

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: separate service account

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: separate service account

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: added chart description

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: lint

Signed-off-by: realanna <anna.reale@dynatrace.com>

Update metrics-operator/chart/Chart.yaml

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update metrics-operator/chart/Chart.yaml

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update metrics-operator/chart/Chart.yaml

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update metrics-operator/chart/Chart.yaml

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update metrics-operator/chart/templates/metrics-manager-config.yaml

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update metrics-operator/chart/templates/metrics-operator-service.yaml

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

feat: lint

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: removed mtrics operator

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: rename manager container

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove duplicate

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove duplicate

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove mod error

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove mod error

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove mod error

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove mod error

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove mod error

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove mod error

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove mod error

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove linter

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove linter

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: remove linter

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: add install

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: add install

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: fix dep

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: fix values file

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: fix values file

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat: add initial metric operator helm chart

Signed-off-by: realanna <anna.reale@dynatrace.com>
@odubajDT
Copy link
Contributor

Please remove this file helm/chart/rendered.yaml

Signed-off-by: realanna <anna.reale@dynatrace.com>
odubajDT
odubajDT previously approved these changes Sep 29, 2023
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit a5ae3de into main Sep 29, 2023
37 checks passed
@odubajDT odubajDT deleted the feat/2181/umbrella_metrics_operator branch September 29, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm metrics-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create helm chart for metrics-operator
5 participants