fix(metrics-operator): use context with timeout for fetching analysis values #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… values Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2213 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 154 154
Lines 9957 9957
=======================================
Hits 8425 8425
Misses 1245 1245
Partials 287 287
Flags with carried forward coverage won't be shown. Click here to find out more. |
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
… fix/dql-provider-debugging
thisthat
reviewed
Oct 2, 2023
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
RealAnna
approved these changes
Oct 2, 2023
thisthat
approved these changes
Oct 3, 2023
StackScribe
pushed a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Oct 13, 2023
… values (keptn#2213) Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analysis controller did not pass the correct context through to the workers for fetching the analysis values, and thus no timeout was applied. This lead to the controller stalling if one of the workers did not finish