Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generalize helm chart #2282

Merged
merged 44 commits into from
Oct 25, 2023
Merged

feat: generalize helm chart #2282

merged 44 commits into from
Oct 25, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Oct 17, 2023 •
edited
Loading

part of #2182

@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 493d4fa
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65377585c4e8f70007311a6e
😎 Deploy Preview https://deploy-preview-2282--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #2282 (2959b64) into main (979b379) will decrease coverage by 0.10%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

❗ Current head 2959b64 differs from pull request most recent head 13a740e. Consider uploading reports for the commit 13a740e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
- Coverage   85.64%   85.54%   -0.10%     
==========================================
  Files         161      161              
  Lines       10246    10190      -56     
==========================================
- Hits         8775     8717      -58     
- Misses       1195     1196       +1     
- Partials      276      277       +1

see 9 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 57.49% <ø> (-0.68%) ⬇️
lifecycle-operator 85.65% <ø> (+0.18%) ⬆️
metrics-operator 87.58% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added the ops label Oct 17, 2023
RealAnna
RealAnna commented Oct 17, 2023
View reviewed changes
common/.helmignore Outdated Show resolved Hide resolved
@RealAnna
added a common chart, included global images options and global labels
e1b34f1 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
build dependencies
49c551f 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: indentation in cert manager
c8d83e7 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: indentation in cert manager
f04e131 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: add annotations
94cfd6d 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: add annotations
029ca2e 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: removed useless things
5e18cbe 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: update common chart
57c12da 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: update test values
9ddbcef 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: remove commons from repo
493d4fa 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: add chart
4a59bdc 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: add chart
afca39b 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: add chart shorter action
bd804b3 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: add chart shorter action
72b3e20 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: add new test changes
02dc708 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: add new test changes
68466ff 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: fix validation of helm
62daa3f 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: update results
9a6eafe 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: fix errors
e04c9af 
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna and others added 7 commits October 25, 2023 10:17
@RealAnna @mowies
Update klt-cert-manager/chart/values.yaml
b8b362f 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna @mowies
Update chart/values.yaml
c57fcf7 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna @mowies
Update klt-cert-manager/chart/values.yaml
bd452fa 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna @mowies
Update klt-cert-manager/chart/values.yaml
ecf3bd7 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna @mowies
Update klt-cert-manager/chart/Chart.yaml
dbda004 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna @mowies
Update lifecycle-operator/chart/Chart.yaml
ade6c83 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
fix: version
ec3c4ed 
Signed-off-by: realanna <anna.reale@dynatrace.com>
mowies
mowies reviewed Oct 25, 2023
View reviewed changes
chart/values.yaml Outdated Show resolved Hide resolved
RealAnna and others added 2 commits October 25, 2023 13:08
@RealAnna @mowies
Update chart/values.yaml
289b181 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
fix: regenerate
32ad294 
Signed-off-by: realanna <anna.reale@dynatrace.com>
mowies
mowies previously approved these changes Oct 25, 2023
View reviewed changes
@RealAnna
fix: remove scheduling gates
2959b64 
Signed-off-by: realanna <anna.reale@dynatrace.com>
bacherfl
bacherfl previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RealAnna
fix: remove scheduling gates
13a740e 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 81334eb into main Oct 25, 2023
40 checks passed
@RealAnna RealAnna deleted the feat/generalize_helm_chart branch October 25, 2023 13:16
This was referenced Oct 25, 2023
Merged
Merged
Merged
Merged
geoffrey1330 pushed a commit to geoffrey1330/lifecycle-toolkit that referenced this pull request Oct 25, 2023
@RealAnna @mowies @geoffrey1330
feat: generalize helm chart (keptn#2282)
ce8e766 
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl bacherfl approved these changes

@mowies mowies mowies approved these changes

@odubajDT odubajDT odubajDT approved these changes

Assignees
No one assigned
Labels
cert-manager documentation Improvements or additions to documentation lifecycle-operator metrics-operator ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RealAnna @bacherfl @mowies @odubajDT