Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more comments for tasks-non-k8s-apps #2293

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

StackScribe
Copy link
Contributor

This PR cuts in comments that came in for #2103 after it was closed.

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Oct 18, 2023
@StackScribe StackScribe added this to the 0.9 milestone Oct 18, 2023
@StackScribe StackScribe requested a review from a team as a code owner October 18, 2023 10:46
@StackScribe StackScribe self-assigned this Oct 18, 2023
@StackScribe StackScribe requested a review from a team as a code owner October 18, 2023 10:46
@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 052f943
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6537b04465e49900081e6f78
😎 Deploy Preview https://deploy-preview-2293--keptn-lifecycle-toolkit.netlify.app/docs/implementing/tasks-non-k8s-apps
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

odubajDT
odubajDT previously approved these changes Oct 18, 2023
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
odubajDT
odubajDT previously approved these changes Oct 19, 2023
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
mowies
mowies previously approved these changes Oct 23, 2023
odubajDT
odubajDT previously approved these changes Oct 24, 2023
@StackScribe StackScribe dismissed stale reviews from odubajDT and mowies via 052f943 October 24, 2023 11:53
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odubajDT odubajDT merged commit 9f0e4aa into keptn:main Oct 24, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants