Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove performance test pipeline #2328

Closed
thisthat opened this issue Oct 24, 2023 · 8 comments · Fixed by #2706
Closed

chore: Remove performance test pipeline #2328

thisthat opened this issue Oct 24, 2023 · 8 comments · Fixed by #2706
Assignees
Milestone

Comments

@thisthat
Copy link
Member

Goal

Remove the Performance Test workflow and relative test code.

Details

We already have the load test workflow that evaluates our performances in an E2E fashion. Furthermore, the performance-test workflow only runs for the lifecycle-operator and doesn't bring any value.
Removing the workflow, we should also looking into removing the relative Makefile entry and relative test code.

DoD

  • workflow is removed
  • left-over test code is removed
  • Makefile cleaned up
@thisthat thisthat added good first issue Good for newcomers status: ready-for-refinement Issue is relevant for the next backlog refinment chore Maintenance github_actions ops labels Oct 24, 2023
@mowies mowies added this to the 0.9 milestone Oct 25, 2023
@mowies mowies modified the milestones: 0.9, 0.10 Nov 6, 2023
@ShivangShandilya
Copy link
Contributor

I would like to work on this @thisthat

@mowies mowies removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Nov 15, 2023
@geoffrey1330
Copy link
Member

Hi @ShivangShandilya Are you still working on this issue or should I take it up?

@ShivangShandilya
Copy link
Contributor

hey @geoffrey1330 sorry I took so long, I'll look at it right away

@ShivangShandilya
Copy link
Contributor

ShivangShandilya commented Nov 24, 2023

hey @thisthat I get that we have to remove Performance Test Workflow and its relative Makefile entry that is this:
Screenshot from 2023-11-24 21-54-41

But I'm unable to find its relative test code under tests/components directory. Can you point me in the right direction?

Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

@thisthat
Copy link
Member Author

thisthat commented Dec 18, 2023

hey @thisthat I get that we have to remove Performance Test Workflow and its relative Makefile entry that is this: Screenshot from 2023-11-24 21-54-41

But I'm unable to find its relative test code under tests/components directory. Can you point me in the right direction?

Hey @ShivangShandilya, I am terribly sorry to have missed your message!
I double-checked and you are right: we don't have any code left over :) we can simply remove the makefile entry and the GH workflow :)

@ShivangShandilya
Copy link
Contributor

It's completely fine, I'll just finish this up then 😄

Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants