Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to crd generator to v0.0.10 #2329

Merged
merged 20 commits into from
Nov 27, 2023
Merged

chore: update to crd generator to v0.0.10 #2329

merged 20 commits into from
Nov 27, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Oct 25, 2023

partial of #2292, this pr adds optional fields and default values, the validation is still missing

Modify the type.tpl to directly show underlying type of alyases instead of linking to nothing.

I annotate every // +optional field in the types just used a regex adding it if the type contains omitempty

Notes: this pr is the first step towards automating CRD reference file as well :)

@RealAnna RealAnna changed the title feat: update to crd gen v 0.0.10 chore: update to crd gen v 0.0.10 Oct 25, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation ops labels Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 80a2212
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65649f2e19bcd900084b0b6c
😎 Deploy Preview https://deploy-preview-2329--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2329 (b4c18ec) into main (95851fa) will not change coverage.
The diff coverage is n/a.

❗ Current head b4c18ec differs from pull request most recent head 0067279. Consider uploading reports for the commit 0067279 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2329   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files         155      155           
  Lines       10178    10178           
=======================================
  Hits         8697     8697           
  Misses       1201     1201           
  Partials      280      280           
Files Coverage Δ
...-operator/apis/lifecycle/v1alpha1/common/common.go 100.00% <ø> (ø)
...operator/apis/lifecycle/v1alpha1/keptnapp_types.go 91.66% <ø> (ø)
...r/apis/lifecycle/v1alpha1/keptnappversion_types.go 97.10% <ø> (ø)
...r/apis/lifecycle/v1alpha1/keptnevaluation_types.go 96.92% <ø> (ø)
...ecycle/v1alpha1/keptnevaluationdefinition_types.go 100.00% <ø> (ø)
...ifecycle/v1alpha1/keptnevaluationprovider_types.go 100.00% <ø> (ø)
...perator/apis/lifecycle/v1alpha1/keptntask_types.go 97.14% <ø> (ø)
...is/lifecycle/v1alpha1/keptntaskdefinition_types.go 100.00% <ø> (ø)
...tor/apis/lifecycle/v1alpha1/keptnworkload_types.go 92.00% <ø> (ø)
.../lifecycle/v1alpha1/keptnworkloadinstance_types.go 90.76% <ø> (ø)
... and 28 more
Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 56.08% <ø> (ø)
lifecycle-operator 84.45% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna
Copy link
Contributor Author

RealAnna commented Nov 3, 2023

@odubajDT I commented on the issue here a list of the refs that are currently pointing to bad documentation, with the new 0.10.0 version anyhow links are borken.

@odubajDT
Copy link
Contributor

odubajDT commented Nov 3, 2023

@odubajDT I commented on the issue here a list of the refs that are currently pointing to bad documentation, with the new 0.10.0 version anyhow links are borken.

Thank you!

@odubajDT odubajDT changed the title chore: update to crd gen v 0.0.10 chore: update to crd generator to v0.0.10 Nov 6, 2023
@RealAnna RealAnna marked this pull request as ready for review November 27, 2023 13:29
@RealAnna RealAnna requested review from a team as code owners November 27, 2023 13:29
odubajDT and others added 2 commits November 27, 2023 14:48
Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: state to string type

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: state to string type

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: labeld string type

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: added missing types

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: fixed

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: fixed

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: fixed

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: fixed version

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: update to crd generator to v0.0.10

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna and others added 6 commits November 27, 2023 14:48
Signed-off-by: realanna <anna.reale@dynatrace.com>
…_types.go

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
cleanup comments

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
…_types.go

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
…es.go

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
odubajDT
odubajDT previously approved these changes Nov 27, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 525ae03 into main Nov 27, 2023
41 checks passed
@odubajDT odubajDT deleted the test/docs_merge branch November 27, 2023 15:47
ahmedavid pushed a commit to ahmedavid/lifecycle-toolkit that referenced this pull request Dec 6, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Co-authored-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: David Ahmadov <ahmedavid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator metrics-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants