Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(operator): Support Progressing state in every phase + refactoring + speed improvements #236

Merged
merged 10 commits into from
Oct 31, 2022
Merged

chore(operator): Support Progressing state in every phase + refactoring + speed improvements #236

merged 10 commits into from
Oct 31, 2022

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Oct 25, 2022 •
edited

  • refactored handling of the phase -> common code for KeptnAppVersion and KeptnWorkloadInstance
  • support Progressing state in each phase
  • improved speed of the whole cycle (30-40s improvement on deploying podtatohead observability example 2:30min -> 1:45min)
  • move duplicated code to controller common package

@odubajDT odubajDT force-pushed the feat/refactoring branch 2 times, most recently from 31b96ca to b3e0543 Compare October 27, 2022 13:23
@odubajDT
com
5f5b38a 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>

added interface for common methods

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

refactored phaseHandler for appVersion and WorkloadInstance

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>

ref

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>

fix

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>

working state

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
create spanHandler
40c3516 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
err handling in spanHandler
092a035 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
working version
674eac7 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
setting progressing state instead of pending
84a5329 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
progressing also during depployment
224b33c 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
speed improvements
6fba715 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT changed the title chore(operator): Refactoring chore(operator): Support Progressing state in every phase + refactoring + speed improvements Oct 27, 2022
@odubajDT odubajDT marked this pull request as ready for review October 27, 2022 13:41
@odubajDT
use method for creating K8s events
963ac06 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
move duplicated code to controller common package
b9e65e9 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
small refactoring
ffe3153 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
thschue
thschue approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

RealAnna
RealAnna approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odubajDT odubajDT merged commit af1da5d into main Oct 31, 2022
@odubajDT odubajDT deleted the feat/refactoring branch October 31, 2022 12:19
@github-actions github-actions bot mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thschue thschue thschue approved these changes

@RealAnna RealAnna RealAnna approved these changes

@thisthat thisthat Awaiting requested review from thisthat

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odubajDT @thschue @RealAnna