Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collectors to Analysis Integration Tests #2697

Closed
1 task
Tracked by #1881
RealAnna opened this issue Dec 19, 2023 · 4 comments · Fixed by #2876
Closed
1 task
Tracked by #1881

Add collectors to Analysis Integration Tests #2697

RealAnna opened this issue Dec 19, 2023 · 4 comments · Fixed by #2876
Assignees
@sudiptob2
Labels
good first issue Good for newcomers tests

Comments

@RealAnna
Copy link
Contributor

RealAnna commented Dec 19, 2023 •
edited
Loading

Given this generic example on how to add a collector to kuttl tests #1834, we should add collectors in each analysis integration test that:

  • collect logs of metrics-operator
  • run a kubectl describe for the analysis CRD

DoD

  • manually verify that when the test fails, the logs and describes are visible in the shell
@RealAnna RealAnna mentioned this issue Dec 19, 2023
Open
5 tasks
@RealAnna RealAnna changed the title analysis (C) Add collectors to analysis integration tests Dec 19, 2023
@RealAnna RealAnna added good first issue Good for newcomers tests labels Dec 19, 2023
@RealAnna RealAnna changed the title Add collectors to analysis integration tests Add collectors to Analysis Integration Tests Dec 19, 2023
@RealAnna RealAnna mentioned this issue Dec 19, 2023
Open
1 task
@mowies mowies added this to the 0.12 milestone Dec 19, 2023
@mowies mowies added the status: ready-for-refinement Issue is relevant for the next backlog refinment label Dec 19, 2023
@odubajDT odubajDT removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Dec 20, 2023
@sudiptob2
Copy link
Member

interested

@github-actions GitHub Actions
Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

@briheet
Copy link

briheet commented Jan 12, 2024

/assign

@RealAnna
Copy link
Contributor Author

Hi @briheet01, unfortunately we do not use an assign bot. This issue is already taken, but feel free to grab an other one here

@sudiptob2 sudiptob2 mentioned this issue Jan 25, 2024
Merged
@UtkarshUmre UtkarshUmre mentioned this issue Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sudiptob2 sudiptob2

Labels
good first issue Good for newcomers tests
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add collectors to analysis integration tests sudiptob2/lifecycle-toolkit
5 participants
@mowies @sudiptob2 @RealAnna @odubajDT @briheet