Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: analysis for non-k8s deployments #2778

Merged
merged 10 commits into from
Jan 12, 2024
Merged

docs: analysis for non-k8s deployments #2778

merged 10 commits into from
Jan 12, 2024

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Jan 10, 2024 •
edited

Summary

This captures information @bacherfl provided in a Slack discussion about using Keptn with deployments that do not run on Kubernetes.

  • Change title of this page to be more appropriate and descriptive
  • Remove metadata from the file
  • Add information about running analyses on a non-k8s deployment
  • Required some restructuring of the file

Fixes # #2760

Checks

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • [ x] My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

@StackScribe
docs: analysis for non-k8s deploymens
9def3da 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Jan 10, 2024
@StackScribe StackScribe added this to the 0.11 milestone Jan 10, 2024
@StackScribe StackScribe self-assigned this Jan 10, 2024
@StackScribe StackScribe requested a review from a team as a code owner January 10, 2024 06:17
@StackScribe
link to the non-k8s page from Migration Guide
8f741de 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe StackScribe changed the title docs: analysis for non-k8s deploymens docs: analysis for non-k8s deployments Jan 10, 2024
@StackScribe
fix typos
d07003c 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@odubajDT odubajDT mentioned this pull request Jan 10, 2024
Closed
21 tasks
StackScribe and others added 5 commits January 10, 2024 15:40
@StackScribe @bacherfl
Update docs-new/docs/use-cases/non-k8s.md
f22024c 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @bacherfl
Update docs-new/docs/use-cases/non-k8s.md
1b26ede 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @bacherfl
Update docs-new/docs/use-cases/non-k8s.md
bbf6eb5 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @bacherfl
Update docs-new/docs/use-cases/non-k8s.md
220f60f 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
Flo comments & other fixes
649b489 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
StackScribe and others added 2 commits January 11, 2024 23:15
@StackScribe @odubajDT
Update docs-new/docs/use-cases/non-k8s.md
6ad7296 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @odubajDT
Update docs-new/docs/use-cases/non-k8s.md
b95d565 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@StackScribe StackScribe merged commit 8e52eda into main Jan 12, 2024
10 checks passed
@StackScribe StackScribe deleted the 0109-analysis-non-k8s branch January 12, 2024 11:58
@StackScribe StackScribe mentioned this pull request Jan 15, 2024
Closed
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@StackScribe @bacherfl
@odubajDT @Vickysomtee
docs: analysis for non-k8s deployments (keptn#2778)
4927233 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@odubajDT odubajDT odubajDT approved these changes

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees

@StackScribe StackScribe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
2.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StackScribe @bacherfl @RealAnna @odubajDT