-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: replace exercise for metrics getting-started #2878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
|
@StackScribe is this still needed? |
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
…into 0123-metrics-gs
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
odubajDT
reviewed
Apr 15, 2024
odubajDT
reviewed
Apr 15, 2024
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
bacherfl
reviewed
Apr 15, 2024
bacherfl
reviewed
Apr 15, 2024
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
|
odubajDT
approved these changes
Apr 22, 2024
bacherfl
approved these changes
Apr 22, 2024
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com> Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the broken exercise in the Keptn Metrics Getting Started Guide with the exercise Adam put together.
The status of this PR is:
Some additional polishing may be appropriate for this guide. Items are summarized in #3413 .
Fixes #2234
Fixes #3413