Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace exercise for metrics getting-started #2878

Merged
merged 16 commits into from
Apr 22, 2024
Merged

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Jan 25, 2024

Summary

This PR replaces the broken exercise in the Keptn Metrics Getting Started Guide with the exercise Adam put together.

The status of this PR is:

  • All of Adam's content has been copied in
  • Most of the old exercise has been removed with appropriate commentary integrated.
  • Upgraded to use v1 library

Some additional polishing may be appropriate for this guide. Items are summarized in #3413 .

Fixes #2234
Fixes #3413

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Jan 25, 2024
@StackScribe StackScribe self-assigned this Jan 25, 2024
@StackScribe StackScribe requested review from a team as code owners January 25, 2024 10:00
@StackScribe StackScribe changed the title docs: WIP replace exercise for metrics getting-started docs: replace exercise for metrics getting-started [WIP] Jan 25, 2024
@StackScribe StackScribe marked this pull request as draft January 25, 2024 10:01
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@github-actions github-actions bot added the ops label Jan 25, 2024
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions github-actions bot added the stale label Feb 16, 2024
@github-actions github-actions bot closed this Feb 24, 2024
@mowies
Copy link
Member

mowies commented Feb 28, 2024

@StackScribe is this still needed?

@StackScribe StackScribe reopened this Apr 3, 2024
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@mowies mowies removed the stale label Apr 10, 2024
@StackScribe StackScribe marked this pull request as ready for review April 12, 2024 05:39
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
StackScribe and others added 2 commits April 17, 2024 00:53
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@StackScribe StackScribe changed the title docs: replace exercise for metrics getting-started [WIP] docs: replace exercise for metrics getting-started Apr 18, 2024
@odubajDT odubajDT merged commit 6a673a5 into main Apr 22, 2024
13 checks passed
@odubajDT odubajDT deleted the 0123-metrics-gs branch April 22, 2024 06:00
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish "Metrics Getting Started" guide create "Getting started with Keptn Custom Metrics" exercise
4 participants