Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix context information in guides #2902

Merged
merged 46 commits into from
Feb 1, 2024
Merged

docs: fix context information in guides #2902

merged 46 commits into from
Feb 1, 2024

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Jan 29, 2024 •
edited

Fixes #2813
Fixes #2814 ?

We agreed to have a separate section on metadata but to integrate linking instructions under otel guide.
I moved the example to access the context into ref guide to taskdefinitions

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 29, 2024
@RealAnna RealAnna changed the title chore: copied ondrejs content docs: fix context information in guides Jan 29, 2024
thisthat
thisthat reviewed Jan 30, 2024
View reviewed changes
docs/docs/guides/tasks.md Outdated Show resolved Hide resolved
docs/docs/guides/tasks.md Outdated Show resolved Hide resolved
docs/docs/guides/tasks.md Outdated Show resolved Hide resolved
docs/docs/guides/context.md Outdated Show resolved Hide resolved
docs/docs/guides/context.md Outdated Show resolved Hide resolved
docs/docs/guides/context.md Outdated Show resolved Hide resolved
docs/docs/guides/context.md Outdated Show resolved Hide resolved
docs/docs/guides/context.md Outdated Show resolved Hide resolved
docs/docs/guides/context.md Outdated Show resolved Hide resolved
docs/docs/guides/context.md Outdated Show resolved Hide resolved
bacherfl
bacherfl reviewed Jan 30, 2024
View reviewed changes
docs/docs/guides/tasks.md Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions github-actions bot added the ops label Jan 31, 2024
RealAnna and others added 3 commits January 31, 2024 12:32
@RealAnna @mowies
Apply suggestions from Mo code review
78cd05d 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna @bacherfl
Update docs/docs/guides/tasks.md
56654f5 
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
chore: add Meg review
58d3802 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
RealAnna and others added 4 commits January 31, 2024 12:39
@RealAnna @mowies
Update docs/docs/guides/otel.md
a881657 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
chore: add Meg review
9f265c0 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
chore: refactor some yaml include
fd10d00 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
chore: refactor some yaml include
595c321 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
mowies
mowies reviewed Jan 31, 2024
View reviewed changes
docs/docs/guides/tasks.md Outdated Show resolved Hide resolved
@RealAnna @mowies
Update docs/docs/guides/tasks.md
373b295 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
mowies
mowies reviewed Jan 31, 2024
View reviewed changes
docs/docs/guides/metadata.md Outdated Show resolved Hide resolved
docs/docs/guides/metadata.md Outdated Show resolved Hide resolved
docs/docs/guides/otel.md Show resolved Hide resolved
RealAnna and others added 2 commits January 31, 2024 14:20
@RealAnna @mowies
Update docs/docs/guides/otel.md
48d82cc 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna @mowies
Update docs/docs/guides/metadata.md
709417a 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
Update docs/docs/guides/metadata.md
b5dbcb6 
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
mowies
mowies previously approved these changes Jan 31, 2024
View reviewed changes
@RealAnna @StackScribe
Update docs/docs/guides/metadata.md
278e8be 
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
chore: fix link for metadata
2c9bb41 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
chore: fix lint
ff4de47 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
chore: fix lint
049972e 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RealAnna RealAnna merged commit 9095a00 into main Feb 1, 2024
11 checks passed
@RealAnna RealAnna deleted the chore/2813/context branch February 1, 2024 07:55
bacherfl added a commit to bacherfl/lifecycle-controller that referenced this pull request Feb 5, 2024
@RealAnna @bacherfl
@StackScribe @mowies
docs: fix context information in guides (keptn#2902)
4d30cc4 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@RealAnna @bacherfl
@StackScribe @mowies @Vickysomtee
docs: fix context information in guides (keptn#2902)
97e797a 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat left review comments

@StackScribe StackScribe StackScribe left review comments

@bacherfl bacherfl bacherfl approved these changes

@mowies mowies mowies approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Milestone
No milestone
5 participants
@RealAnna @thisthat @bacherfl @StackScribe @mowies