Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce failure mechanism for WorkloadDeployment phase #3134

Closed
7 tasks done
Tracked by #218
odubajDT opened this issue Feb 27, 2024 · 0 comments · Fixed by #3160
Closed
7 tasks done
Tracked by #218

Introduce failure mechanism for WorkloadDeployment phase #3134

odubajDT opened this issue Feb 27, 2024 · 0 comments · Fixed by #3160
Assignees
Labels
enhancement New feature or request lifecycle-operator

Comments

@odubajDT
Copy link
Contributor

odubajDT commented Feb 27, 2024

Description

In pre/post-deploment task or evaluation phases as well as promotion phase we have a failure mechanism to fail the phase either after certain amount of retries or after a timeout. We should be implement similar functionality for the WorkloadDeployment phase.

Details

We should introduce .status.DeploymentStartTime into KeptnWorkloadVersion CRD. Afterwards we should adapt the logic of KeptnWorkloadVersionRecolciler to set the .status.DeploymentStartTime and periodically check that the current time is not beyond the start time + timeout.

The value of the timeout will be set by a new parameter in KeptnConfig

A small PoC is available here.

DoD

  • KeptnConfig has a new parameter for DeploymentTimeout
  • the parameter of KeptnConfig is reconciled by KeptnConfigReconciler
  • new parameter KeptnWorkloadVersion are introduced
  • KeptnWorkloadVersionRecolciler is adapted
  • unit tests
  • integration tests
  • new functionality is documented

Note

Please try to provide the implementation in multiple small PRs and not a single big PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lifecycle-operator
Projects
Archived in project
1 participant