Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix info about %include for sample files #3246

Merged
merged 7 commits into from
Mar 21, 2024
Merged

docs: fix info about %include for sample files #3246

merged 7 commits into from
Mar 21, 2024

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Mar 12, 2024 •
edited
Loading

This PR does the following:

  • Corrects the syntax given for %include lines
  • Moves and expands the info about including code files from "guidelines" to "coding the docs"

@StackScribe
docs: fix info about %include for sample files
35bdff2 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe StackScribe added bug Something isn't working documentation Improvements or additions to documentation labels Mar 12, 2024
@StackScribe StackScribe added this to the 2.0.0 milestone Mar 12, 2024
@StackScribe StackScribe self-assigned this Mar 12, 2024
@StackScribe StackScribe requested review from a team as code owners March 12, 2024 07:13
@StackScribe
xref structure
ab9c23a 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
StackScribe and others added 2 commits March 12, 2024 01:28
@StackScribe
try to fix include line
2d84aec 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@mowies
Merge branch 'main' into 0311-doc-assets
ad8e8e6
StackScribe and others added 2 commits March 13, 2024 23:29
@StackScribe @mowies
Update docs/docs/contribute/docs/code-docs.md
b319f68 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @mowies
Update docs/docs/contribute/docs/code-docs.md
2adf062 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@mowies
Update docs/docs/contribute/docs/code-docs.md
ce591df 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@RealAnna RealAnna merged commit bc1ead5 into main Mar 21, 2024
11 checks passed
@RealAnna RealAnna deleted the 0311-doc-assets branch March 21, 2024 12:09
@keptn-bot keptn-bot mentioned this pull request Mar 21, 2024
Merged
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@StackScribe @mowies @Vickysomtee
docs: fix info about %include for sample files (keptn#3246)
45751df 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies approved these changes

@RealAnna RealAnna RealAnna approved these changes

Assignees

@StackScribe StackScribe

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StackScribe @mowies @RealAnna