Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm-chart): introduce cert volumes to metrics and lifecycle operators #3247

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

odubajDT
Copy link
Contributor

Fixes: #3242

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.96%. Comparing base (1d099d7) to head (ba4a436).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3247      +/-   ##
==========================================
- Coverage   87.00%   86.96%   -0.04%     
==========================================
  Files         162      162              
  Lines        8647     8647              
==========================================
- Hits         7523     7520       -3     
- Misses        832      834       +2     
- Partials      292      293       +1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 57.23% <ø> (-0.25%) ⬇️
lifecycle-operator 86.75% <ø> (ø)
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT marked this pull request as ready for review March 12, 2024 09:46
@odubajDT odubajDT requested a review from a team as a code owner March 12, 2024 09:46
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mowies mowies changed the title fix: introduce cert volumes to metrics and lifecycle operators fix(helm-chart): introduce cert volumes to metrics and lifecycle operators Mar 12, 2024
@odubajDT odubajDT merged commit b7744dd into keptn:main Mar 12, 2024
36 of 37 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
…ators (keptn#3247)

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of cert-manager.io does not work due to missing cert injection
3 participants