Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deploy Keptn via ArgoCD #3256

Merged
merged 10 commits into from
Mar 14, 2024
Merged

docs: deploy Keptn via ArgoCD #3256

merged 10 commits into from
Mar 14, 2024

Conversation

odubajDT
Copy link
Contributor

Fixes: #3245

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 13, 2024
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@github-actions github-actions bot added the ops label Mar 13, 2024
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@odubajDT odubajDT marked this pull request as ready for review March 13, 2024 10:28
@odubajDT odubajDT requested review from a team as code owners March 13, 2024 10:28
docs/docs/installation/configuration/argo.md Outdated Show resolved Hide resolved
docs/docs/installation/configuration/argo.md Outdated Show resolved Hide resolved
docs/docs/installation/configuration/assets/argo-app.yaml Outdated Show resolved Hide resolved
docs/docs/installation/index.md Outdated Show resolved Hide resolved
docs/docs/installation/configuration/argo.md Outdated Show resolved Hide resolved
docs/docs/installation/configuration/argo.md Outdated Show resolved Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
mowies
mowies previously approved these changes Mar 13, 2024
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bacherfl
bacherfl previously approved these changes Mar 14, 2024
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a paragraph pointing to this in the installation trubleshooting guide?

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe consider my comment above

RealAnna

This comment was marked as duplicate.

RealAnna

This comment was marked as duplicate.

RealAnna

This comment was marked as duplicate.

RealAnna

This comment was marked as duplicate.

@mowies
Copy link
Member

mowies commented Mar 14, 2024

maybe we can even remove the argo point from the troubleshooting guide now?

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT dismissed stale reviews from bacherfl and mowies via 98a7311 March 14, 2024 07:56
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit b1eae61 into keptn:main Mar 14, 2024
11 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keptn uninstallation doesn't work when managed by ArgoCD
4 participants