Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lifecycle-operator): remove noops tracer for evaluations #3290

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Mar 19, 2024

fixes #3243

image

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (62a8c14) to head (8b491f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3290      +/-   ##
==========================================
+ Coverage   87.00%   87.02%   +0.02%     
==========================================
  Files         162      162              
  Lines        8647     8663      +16     
==========================================
+ Hits         7523     7539      +16     
  Misses        832      832              
  Partials      292      292              
Files Coverage Δ
...cle/keptnappversion/reconcile_prepostevaluation.go 74.07% <100.00%> (+10.91%) ⬆️
...eptnworkloadversion/reconcile_prepostevaluation.go 92.59% <100.00%> (+3.11%) ⬆️
Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.04% <100.00%> (+0.55%) ⬆️
lifecycle-operator 86.50% <0.00%> (-0.25%) ⬇️
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna marked this pull request as ready for review March 19, 2024 10:02
@RealAnna RealAnna requested a review from a team as a code owner March 19, 2024 10:02
@mowies mowies changed the title fix: remove noops tracer for evaluations in lifecycle-operator fix(lifecycle-operator): remove noops tracer for evaluations Mar 19, 2024
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RealAnna RealAnna merged commit 4948dc5 into main Mar 19, 2024
38 checks passed
@RealAnna RealAnna deleted the fix/3243/inherit-span branch March 19, 2024 12:01
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
)

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Span of individual evaluations missing from app deployment trace
3 participants