Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: reduce blogpost title length to fit into social card #3294

Merged
merged 4 commits into from
Mar 19, 2024
Merged

docs: reduce blogpost title length to fit into social card #3294

merged 4 commits into from
Mar 19, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Mar 19, 2024 •
edited

This PR

  • adjusts the release candidate blogpost title so that it fits into the social card while sharing (see screenshot)
  • set the post slug to the old one so that the URL that is already released stays the same as before
  • adjusts the social card background color to use the default Keptn color

Before

Screenshot 2024-03-19 at 11 51 38

After

Screenshot 2024-03-19 at 11 51 10

@mowies
docs: reduce blogpost title length to fit into social card
0129d6d 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 19, 2024
@mowies
use old post slug to keep the old url
8a280ea 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies marked this pull request as ready for review March 19, 2024 10:39
@mowies mowies requested review from a team as code owners March 19, 2024 10:39
@mowies
change social card background color to use keptn default color
9e9f7d4 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
Trigger Build
9bd85d2 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit 15717bd into keptn:main Mar 19, 2024
14 checks passed
@keptn-bot keptn-bot mentioned this pull request Mar 19, 2024
Merged
@mowies mowies deleted the adjust-blogpost-title branch March 19, 2024 12:02
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@mowies @Vickysomtee
docs: reduce blogpost title length to fit into social card (keptn#3294)
c7b54f6 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl bacherfl approved these changes

@odubajDT odubajDT odubajDT approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mowies @bacherfl @odubajDT