Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add use case page for KEDA #3349

Merged
merged 16 commits into from
Mar 26, 2024
Merged

docs: add use case page for KEDA #3349

merged 16 commits into from
Mar 26, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Mar 26, 2024

This PR

@mowies
docs: add use case page for KEDA
a304102 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
add sample files
528e85a 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
WIP
a324b2c 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
add more sample files
b907855 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
more text adjustments
f70840f 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
adjust shell outputs
e45ee4b 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 26, 2024
@mowies
markdown issues
57e3d74 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try adjusting code blocks indentation
0bf0efe 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
adjust spelling, fix code blocks again
8862ca5 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@github-actions github-actions bot added the ops label Mar 26, 2024
@mowies
ignore mdl rule
e0156bc 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix down mdl rule
0b3df54 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies marked this pull request as ready for review March 26, 2024 10:24
@mowies mowies requested review from a team as code owners March 26, 2024 10:24
StackScribe
StackScribe reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few comments for your consideration.

@mowies
fixes from review
d5c0f29 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
odubajDT
odubajDT reviewed Mar 26, 2024
View reviewed changes
docs/docs/use-cases/keda.md Show resolved Hide resolved
docs/docs/use-cases/keda.md Outdated Show resolved Hide resolved
docs/docs/use-cases/keda.md Outdated Show resolved Hide resolved
mowies and others added 3 commits March 26, 2024 14:24
@mowies
fix namespaces
e943458 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies @bacherfl
Update docs/docs/use-cases/keda.md
6c12960 
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
move shell content to files
2765745 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (ad2de72) to head (d30ee65).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
+ Coverage   87.02%   88.06%   +1.03%     
==========================================
  Files         162      176      +14     
  Lines        8665     9604     +939     
==========================================
+ Hits         7541     8458     +917     
- Misses        832      853      +21     
- Partials      292      293       +1

see 18 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.77% <ø> (+0.73%) ⬆️
lifecycle-operator 88.08% <ø> (+1.57%) ⬆️
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies
remove mention of k8s custom metrics API
d30ee65 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mowies mowies merged commit 3ebd454 into keptn:main Mar 26, 2024
38 checks passed
@mowies mowies deleted the keda-use-case branch March 26, 2024 14:11
@keptn-bot keptn-bot mentioned this pull request Mar 26, 2024
Merged
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@mowies @bacherfl @Vickysomtee
docs: add use case page for KEDA (keptn#3349)
41e20dd 
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackScribe StackScribe StackScribe left review comments

@bacherfl bacherfl bacherfl approved these changes

@odubajDT odubajDT odubajDT approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create use-case about how to scale workloads with KEDA
4 participants
@mowies @bacherfl @StackScribe @odubajDT