Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workloads are deployed although not part of an application #372

Closed
Tracked by #398
thisthat opened this issue Nov 10, 2022 · 1 comment · Fixed by #377
Closed
Tracked by #398

Workloads are deployed although not part of an application #372

thisthat opened this issue Nov 10, 2022 · 1 comment · Fixed by #377
Assignees
Labels
bug Something isn't working
Milestone

Comments

@thisthat
Copy link
Member

Problem

A workload is annotated with recommended K8s labels (in particular part-of) but it is not part of the KeptnApp manifest. The Lifecycle Toolkit deploys the workload anyway.

Desired result: The Lifecycle toolkit prevents the workload to be bound to a node since it is not part of the release bracket.

Replication steps

Screenshot 2022-11-10 at 11 14 50

@thisthat thisthat added the bug Something isn't working label Nov 10, 2022
@thisthat thisthat added this to the 0.5.x milestone Nov 10, 2022
@thschue thschue modified the milestones: 0.5.x, 0.4.1 Nov 11, 2022
@bacherfl bacherfl self-assigned this Nov 11, 2022
@AloisReitbauer
Copy link
Member

I think this is also an example for implicit mode. When implicit is enabled it would be added. Otherwise not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
4 participants