Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(operator): Also consider StatefulSets/DaemonSets when checking Workload Deployment state #406

Merged
merged 20 commits into from
Nov 15, 2022
Merged

fix(operator): Also consider StatefulSets/DaemonSets when checking Workload Deployment state #406

merged 20 commits into from
Nov 15, 2022

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Nov 14, 2022 •
edited

Closes #373

@codecov
Copy link

codecov bot commented Nov 14, 2022 •
edited

Codecov Report

Merging #406 (0133538) into main (46524a7) will increase coverage by 0.92%.
The diff coverage is 63.41%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   27.44%   28.36%   +0.92%     
==========================================
  Files          16       16              
  Lines        1483     1484       +1     
==========================================
+ Hits          407      421      +14     
+ Misses       1056     1040      -16     
- Partials       20       23       +3
Impacted Files Coverage Δ
...or/controllers/keptnworkloadinstance/controller.go 10.25% <ø> (ø)
...keptnworkloadinstance/reconcile_deploymentstate.go 62.29% <63.41%> (+22.29%) ⬆️
Flag Coverage Δ
keptn-lifecycle-operator 32.54% <63.41%> (+1.08%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl
fix(operator): Also consider StatefulSets when checking Workload Depl…
89f403e 
…oyment state

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fix(operator): Detect progression of StatefulSets reference in WLI
ce5d31b 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
adapted component test
68951ed 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed component test
2b4d3d5 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed component test
48d1037 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed component test: update status of appVersion
edb1f1c 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed component test: update status of appVersion
d45241c 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed component test: update status of appVersion
c5464cf 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed component test: update status of StatefulSet
487754c 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed component test: update status of StatefulSet
150a429 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added component test for DaemonSet
36c6d95 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added unit tests
966ed57 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
adapted component tests
0c71d78 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added integration test for daemonSet
710b05f 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
adapt component test
f0e0666 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fix typo
90983a2 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added permission for retrieving daemonsets
16904d0 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added rollme annotation to template
077fdc4 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
edit assertion
538f9f7 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl marked this pull request as ready for review November 15, 2022 11:58
@bacherfl
updated roles
0133538 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
odubajDT
odubajDT approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thschue
thschue approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 27c189f into keptn:main Nov 15, 2022
@keptn-bot keptn-bot mentioned this pull request Nov 15, 2022
Merged
thschue pushed a commit that referenced this pull request Nov 15, 2022
@bacherfl
fix(operator): Also consider StatefulSets/DaemonSets when checking Wo…
0567018 
…rkload Deployment state (#406)

Closes #373
@bacherfl bacherfl deleted the fix/statefulset-ref branch November 16, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thschue thschue thschue approved these changes

@odubajDT odubajDT odubajDT approved these changes

@thisthat thisthat Awaiting requested review from thisthat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StatefulSet does not move to the next phase correctly
3 participants
@bacherfl @thschue @odubajDT