Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set default of 1 for KeptnApp revision field #513

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

mowies
Copy link
Member

@mowies mowies commented Dec 13, 2022

This PR

  • sets a default of 1 if the KeptnApp revision field is not set

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies marked this pull request as ready for review December 13, 2022 10:27
bacherfl
bacherfl previously approved these changes Dec 13, 2022
RealAnna
RealAnna previously approved these changes Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #513 (84878e9) into main (647c6a1) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   48.76%   48.78%   +0.01%     
==========================================
  Files          55       55              
  Lines        5143     5143              
==========================================
+ Hits         2508     2509       +1     
+ Misses       2528     2527       -1     
  Partials      107      107              
Impacted Files Coverage Δ
operator/api/v1alpha2/keptnapp_types.go 91.66% <ø> (ø)
...ptnworkloadinstance/reconcile_prepostevaluation.go 81.81% <0.00%> (-9.10%) ⬇️
...or/controllers/keptnworkloadinstance/controller.go 77.31% <0.00%> (+0.51%) ⬆️
...ptnworkloadinstance/reconcile_prepostdeployment.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 51.85% <ø> (+1.77%) ⬆️
keptn-lifecycle-operator 47.27% <ø> (ø)
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies dismissed stale reviews from RealAnna and bacherfl via 84878e9 December 13, 2022 10:31
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies merged commit a5cb3f2 into keptn:main Dec 13, 2022
@mowies mowies deleted the add-keptnapp-default-revision branch December 13, 2022 12:18
@keptn-bot keptn-bot mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants