Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate SBOMs for container images on release #571

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Jan 9, 2023

This PR

  • generates SBOMs for all 3 container images upon release
  • the SBOMs are attached to the newly created release in JSON format

Fixes #300

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #571 (5489e86) into main (9516fcf) will decrease coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   49.92%   49.81%   -0.11%     
==========================================
  Files          60       60              
  Lines        5528     5528              
==========================================
- Hits         2760     2754       -6     
- Misses       2661     2665       +4     
- Partials      107      109       +2     
Impacted Files Coverage Δ
...ptnworkloadinstance/reconcile_prepostdeployment.go 81.81% <0.00%> (-9.10%) ⬇️
...or/controllers/keptnworkloadinstance/controller.go 77.04% <0.00%> (-1.54%) ⬇️
Flag Coverage Δ
component-tests 50.58% <ø> (+0.94%) ⬆️
keptn-lifecycle-operator 47.85% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies changed the title try out sbom action feat: Generate SBOMs for container images on release Jan 9, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies mowies changed the title feat: Generate SBOMs for container images on release feat: generate SBOMs for container images on release Jan 9, 2023
@mowies mowies marked this pull request as ready for review January 9, 2023 13:22
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 72fe001 into keptn:main Jan 10, 2023
@keptn-bot keptn-bot mentioned this pull request Jan 10, 2023
@mowies mowies deleted the sboms branch January 10, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SBOM to releases
3 participants