Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keptn evaluations consume KeptnMetrics #609

Closed
4 tasks done
Tracked by #524
thisthat opened this issue Jan 12, 2023 · 0 comments · Fixed by #661
Closed
4 tasks done
Tracked by #524

Keptn evaluations consume KeptnMetrics #609

thisthat opened this issue Jan 12, 2023 · 0 comments · Fixed by #661
Assignees
@odubajDT
Labels
enhancement New feature or request
Milestone
0.6

Comments

@thisthat
Copy link
Member

thisthat commented Jan 12, 2023 •
edited by odubajDT
Loading

Goal

KLT provides an out-of-the-box provider for fetching SLI data from KeptnMetrics.

Technical Details

The Evaluation controller should accept KeptnMetric as a source of SLI definition. This requires adding this entry to this switch.

Acceptance Criteria

  • When the value of the source field is KeptnMetric in the KeptnEvaluation CRD, then the value is resolved by looking at the KeptnMetric CRD with name equal to the spec.objectives[i].name value of KeptnEvaluationDefinition. Note, the query field is ignored.

DoD

  • SLI can be fetched from KeptnMetric CRDs
  • Unit tests
  • Component tests

Dependencies
@thisthat thisthat changed the title Keptn evaluations consume KeptnMetrics Keptn evaluations consume KeptnMetrics Jan 12, 2023
@thisthat thisthat added the enhancement New feature or request label Jan 12, 2023
@thisthat thisthat added this to the 0.6 milestone Jan 12, 2023
This was referenced Jan 16, 2023
Closed
Closed
@odubajDT odubajDT self-assigned this Jan 18, 2023
@odubajDT odubajDT mentioned this issue Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odubajDT odubajDT

Labels
enhancement New feature or request
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

feat(operator): evaluation controller uses KeptnMetric as SLI provider
2 participants
@thisthat @odubajDT