Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scheduler): added new scheduler tests #634

Merged
merged 8 commits into from
Jan 18, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Jan 17, 2023

Closes #317

  • Adds a few tests in the scheduler to cover labels and pending status in case of failure.

notes:

eventually, when there will be compatibility between the libraries this test will be merged with operator in a proper e2e tests

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #634 (42bf0ac) into main (c5463c6) will increase coverage by 0.54%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   54.23%   54.78%   +0.54%     
==========================================
  Files          77       78       +1     
  Lines        6446     6515      +69     
==========================================
+ Hits         3496     3569      +73     
+ Misses       2799     2796       -3     
+ Partials      151      150       -1     
Impacted Files Coverage Δ
operator/controllers/common/taskhandler.go 78.78% <0.00%> (-0.93%) ⬇️
operator/controllers/common/phasehandler.go 81.25% <0.00%> (-0.57%) ⬇️
operator/webhooks/pod_mutating_webhook.go 35.83% <0.00%> (ø)
operator/controllers/common/helperfunctions.go 100.00% <0.00%> (ø)
operator/controllers/common/evaluationhandler.go 79.71% <0.00%> (ø)
operator/apis/lifecycle/v1alpha2/common/phases.go 100.00% <0.00%> (ø)
...rator/controllers/lifecycle/keptnapp/controller.go 68.42% <0.00%> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 38.31% <0.00%> (ø)
...ontrollers/lifecycle/keptnevaluation/controller.go 0.00% <0.00%> (ø)
...or/controllers/lifecycle/interfaces/eventobject.go 62.50% <0.00%> (ø)
... and 8 more
Flag Coverage Δ
component-tests 53.74% <ø> (+1.29%) ⬆️
keptn-cert-manager 67.72% <ø> (ø)
keptn-lifecycle-operator 52.13% <ø> (+0.53%) ⬆️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna force-pushed the chore/317/add_tests_to_scheduler branch from f110c3a to 1c6dd2d Compare January 17, 2023 12:25
@RealAnna RealAnna changed the title added new e2e tests added new schedler tests Jan 17, 2023
@RealAnna RealAnna changed the title added new schedler tests added new scheduler tests Jan 17, 2023
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna RealAnna marked this pull request as ready for review January 17, 2023 13:49
@RealAnna RealAnna changed the title added new scheduler tests chore(scheduler): added new scheduler tests Jan 17, 2023
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
scheduler/test/e2e/scheduler_test.go Outdated Show resolved Hide resolved
scheduler/test/e2e/scheduler_test.go Outdated Show resolved Hide resolved
scheduler/test/e2e/scheduler_test.go Outdated Show resolved Hide resolved
scheduler/test/e2e/scheduler_test.go Outdated Show resolved Hide resolved
scheduler/test/e2e/scheduler_test.go Outdated Show resolved Hide resolved
scheduler/test/e2e/scheduler_test.go Outdated Show resolved Hide resolved
scheduler/test/e2e/scheduler_test.go Outdated Show resolved Hide resolved
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RealAnna RealAnna merged commit 2e47b92 into main Jan 18, 2023
@RealAnna RealAnna deleted the chore/317/add_tests_to_scheduler branch January 18, 2023 13:28
@keptn-bot keptn-bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing: More e2e tests for Keptn Scheduler
3 participants