Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KeptnConfig API #651

Merged
merged 19 commits into from
Feb 1, 2023
Merged

feat: add KeptnConfig API #651

merged 19 commits into from
Feb 1, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Jan 18, 2023

This PR

  • adds the new KeptnConfig CRD under the options API group
  • moves the OTel setup code into a separate otel_utils.go common file
  • removes the OTel collector URL env var from the operator

Closes #593

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #651 (6cdb3e3) into main (6ddbb6d) will increase coverage by 0.30%.
The diff coverage is 70.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
+ Coverage   57.38%   57.69%   +0.30%     
==========================================
  Files          89       91       +2     
  Lines        7012     7243     +231     
==========================================
+ Hits         4024     4179     +155     
- Misses       2822     2894      +72     
- Partials      166      170       +4     
Impacted Files Coverage Δ
operator/apis/lifecycle/v1alpha2/common/common.go 100.00% <ø> (ø)
operator/controllers/common/otel_utils.go 66.17% <66.17%> (ø)
operator/controllers/common/metrics.go 84.48% <82.35%> (-2.85%) ⬇️
...ator/controllers/options/keptnconfig_controller.go 82.50% <90.90%> (ø)
Flag Coverage Δ
component-tests 48.82% <0.00%> (-4.44%) ⬇️
keptn-lifecycle-operator 53.60% <70.47%> (+0.49%) ⬆️
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
…d to make testing easier, add unit tests

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

remove suite test since its not needed, add first unit tests

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

add a test

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

remove todo

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

refactor otel utils to make testing easier

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

refactoring

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

more refactoring

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies marked this pull request as ready for review January 31, 2023 15:09
Signed-off-by: realanna <anna.reale@dynatrace.com>

propose refactoring

Signed-off-by: realanna <anna.reale@dynatrace.com>

propose refactoring

Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
bacherfl
bacherfl previously approved these changes Feb 1, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies merged commit 9784216 into keptn:main Feb 1, 2023
@mowies mowies deleted the config-crd branch February 1, 2023 09:24
@keptn-bot keptn-bot mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Options/Config CRD for KLT with OTel collector URL
4 participants