Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: requeue KeptnMetric and process them only when deadline is met #681

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

thisthat
Copy link
Member

Signed-off-by: Giovanni Liva giovanni.liva@dynatrace.com

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #681 (002d357) into main (a3b0f7b) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   56.36%   56.44%   +0.08%     
==========================================
  Files          82       82              
  Lines        6683     6684       +1     
==========================================
+ Hits         3767     3773       +6     
+ Misses       2756     2753       -3     
+ Partials      160      158       -2     
Impacted Files Coverage Δ
...ator/controllers/metrics/keptnmetric_controller.go 65.62% <0.00%> (-1.05%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 78.24% <0.00%> (+1.38%) ⬆️
...ptnworkloadinstance/reconcile_prepostevaluation.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 53.54% <ø> (+0.70%) ⬆️
keptn-cert-manager 67.56% <ø> (ø)
keptn-lifecycle-operator 52.01% <0.00%> (-0.01%) ⬇️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisthat thisthat marked this pull request as ready for review January 23, 2023 16:58
@thisthat thisthat merged commit 39dd3f8 into keptn:main Jan 25, 2023
@thisthat thisthat deleted the perf/queue-metrics branch January 25, 2023 07:22
@keptn-bot keptn-bot mentioned this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants