Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): disable cache for secrets #727

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Jan 31, 2023

fixed need for secret list clusterrole

added a test that proves operator manges to reach a line after the problematic get secret

Signed-off-by: realanna <anna.reale@dynatrace.com>
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #727 (8b91dd7) into main (e271162) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   57.44%   57.35%   -0.09%     
==========================================
  Files          89       89              
  Lines        7012     7012              
==========================================
- Hits         4028     4022       -6     
- Misses       2819     2823       +4     
- Partials      165      167       +2     
Impacted Files Coverage Δ
...ptnworkloadinstance/reconcile_prepostevaluation.go 81.81% <0.00%> (-9.10%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 81.44% <0.00%> (-1.36%) ⬇️
Flag Coverage Δ
component-tests 53.25% <ø> (-0.53%) ⬇️
keptn-lifecycle-operator 53.10% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: realanna <anna.reale@dynatrace.com>

fix(operator): kuttl test

Signed-off-by: realanna <anna.reale@dynatrace.com>

fix(operator): kuttl test

Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna RealAnna force-pushed the fix/metric_controller_security_ branch from af2f724 to 549260b Compare January 31, 2023 12:53
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna RealAnna marked this pull request as ready for review January 31, 2023 13:08
operator/main.go Outdated Show resolved Hide resolved
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 6ddbb6d into main Jan 31, 2023
@RealAnna RealAnna deleted the fix/metric_controller_security_ branch January 31, 2023 14:21
@keptn-bot keptn-bot mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants