Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add KeptnAppCreationRequestTimeout field to KeptnConfig API #735

Merged
merged 1 commit into from
Feb 6, 2023
Merged

feat: add KeptnAppCreationRequestTimeout field to KeptnConfig API #735

merged 1 commit into from
Feb 6, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Feb 1, 2023

This PR

  • adds the new KeptnAppCreationRequestTimeout to the KeptnConfig API

Part of #695

@mowies
feat: add KeptnAppCreationRequestTimeout field to KeptnConfig API
bededb0 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 1, 2023 •
edited
Loading

Codecov Report

Merging #735 (bededb0) into main (9784216) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   57.69%   57.69%           
=======================================
  Files          91       91           
  Lines        7243     7243           
=======================================
  Hits         4179     4179           
  Misses       2894     2894           
  Partials      170      170
Flag Coverage Δ
component-tests 47.93% <ø> (-0.89%) ⬇️
keptn-lifecycle-operator 53.60% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

thschue
thschue approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit eda3f23 into keptn:main Feb 6, 2023
@keptn-bot keptn-bot mentioned this pull request Feb 6, 2023
Merged
@mowies mowies deleted the app-creation-req-timeout-2 branch February 7, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thschue thschue thschue approved these changes

@odubajDT odubajDT odubajDT approved these changes

@thisthat thisthat Awaiting requested review from thisthat

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mowies @thschue @odubajDT