Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata to helm chart #737

Merged
merged 7 commits into from
Feb 8, 2023
Merged

feat: add metadata to helm chart #737

merged 7 commits into from
Feb 8, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Feb 1, 2023

This PR

  • adds helm and artifacthub metadata to the KLT helm chart
  • some annotations were omitted because they are too much effort and would need to be updated manually:
    • CRDs
    • CRD examples

Fixes #596

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
(cherry picked from commit f998bc0)
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #737 (caecc7b) into main (bc75f00) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   57.69%   57.75%   +0.05%     
==========================================
  Files          91       91              
  Lines        7243     7243              
==========================================
+ Hits         4179     4183       +4     
+ Misses       2894     2891       -3     
+ Partials      170      169       -1     
Impacted Files Coverage Δ
...lers/lifecycle/keptnworkloadinstance/controller.go 82.80% <0.00%> (+1.80%) ⬆️
Flag Coverage Δ
component-tests 48.40% <ø> (-0.58%) ⬇️
keptn-lifecycle-operator 53.60% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies changed the title feat: add metadata to helm chart feat(helm-chart): add metadata to helm chart Feb 1, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies changed the title feat(helm-chart): add metadata to helm chart feat: add metadata to helm chart Feb 1, 2023
@mowies mowies marked this pull request as ready for review February 1, 2023 11:55
@mowies mowies marked this pull request as draft February 1, 2023 11:55
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
This reverts commit 461c0d2.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies marked this pull request as ready for review February 8, 2023 07:59
@mowies mowies merged commit b5c5801 into keptn:main Feb 8, 2023
@mowies mowies deleted the helm-metadata branch February 8, 2023 12:20
@keptn-bot keptn-bot mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up artifact hub annotations
3 participants