feat: configurable imagePullPolicy via Helm

[sudiptob2]

Fixes #721

Required tasks

• value file contains a new value imagePullPolicy
• the value is patched to all the deployments in our helm overlay (modify this )
• default value set to Always
• Run ./.github/scripts/generate-helm-docs.sh to update the helm chart docs
• Add readme-generator-for-helm in gitignore

[sudiptob2]

I am pretty beginner in keptn. I would appreciate your valuable comment on the PR weather it is on the right track or not. 💯

[codecov]

Codecov Report

Merging #740 (054d858) into main (bab6a6f) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   57.69%   57.75%   +0.05%     
==========================================
  Files          91       91              
  Lines        7243     7243              
==========================================
+ Hits         4179     4183       +4     
+ Misses       2894     2891       -3     
+ Partials      170      169       -1     

Impacted Files	Coverage Δ
...lers/lifecycle/keptnworkloadinstance/controller.go	82.80% <0.00%> (+1.80%)	⬆️

Flag	Coverage Δ
component-tests	48.56% <ø> (+0.62%)	⬆️
keptn-lifecycle-operator	53.60% <ø> (ø)
klt-cert-manager	67.50% <ø> (ø)
scheduler	21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[sudiptob2]

@thisthat @thschue awaiting a review on this PR

[RealAnna]

Thank you for the contribution @sudiptob2 LGTM only one thing to do still: our helm docs are autogenerated, so any time you add one new value you need to run the script in ./.github/scripts/generate-helm-docs.sh to re-generate the docs.

Sorry we forgot to mention that in the ticket 😸

[sudiptob2]

@RealAnna Thanks much for helping me out, I am going to run that script and make another commit.
One this is to mention is that This ticket is the most detailed ticket I have ever found 🚀 🚀

[sudiptob2]

Could you please please mention where the script is, I can not find the generate-helm-docs.sh file in the project @RealAnna

[RealAnna]

Could you please please mention where the script is, I can not find the generate-helm-docs.sh file in the project @RealAnna

https://github.com/keptn/lifecycle-toolkit/blob/main/.github/scripts/generate-helm-docs.sh :)

[sudiptob2]

Oh Its in the kep

Could you please please mention where the script is, I can not find the generate-helm-docs.sh file in the project @RealAnna

https://github.com/keptn/lifecycle-toolkit/blob/main/.github/scripts/generate-helm-docs.sh :)

Yes, I also found it in the repo, but not in my version. understood, I have to sync the fork. It's been added recently I guess. Thanks a lot @RealAnna

[sudiptob2]

I have a confusion, in the generate-helm-docs.sh we pull a doc generator project in the current directory ref
Should I add this directory to gitignore ? @RealAnna

[RealAnna]

I have a confusion, in the generate-helm-docs.sh we pull a doc generator project in the current directory ref Should I add this directory to gitignore ? @RealAnna
@sudiptob2 yes it can be nice to add it into the git ingore indeed, thanks for noticing!

[RealAnna]

LGTM!

[odubajDT]

I already reverted the requested changes, sorry one more time for taking you to the wrong path and thanks for contribution!

[sudiptob2]

I already reverted the requested changes, sorry one more time for taking you to the wrong path and thanks for contribution!

Thanks much all, can't belive I am able to make a contribution even as a beginner. 🚀 Really appreciate your help @odubajDT Looking forward to do more

[sudiptob2]

hi, @odubajDT @RealAnna still one pipeline check is failing. Could you please suggest to me the next step?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[sudiptob2]

I updated the branch with main, now I guess all checks are passed. However please let me know if I have to take any further steps.

[thisthat]

LGTM, thank you @sudiptob2 for your contribution 🙌