-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): dynamically create tracers during reconciliation #804
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 58.33% 58.65% +0.31%
==========================================
Files 97 97
Lines 7518 7542 +24
==========================================
+ Hits 4386 4424 +38
+ Misses 2941 2930 -11
+ Partials 191 188 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
c1b5406
to
652ac00
Compare
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work, LGTM!
Closes #802
This PR fixes the problem that spans were not visible after setting the Otel exporter during runtime, as the CRD controllers all used the otel tracers they were given during startup. With this PR, the tracers are now maintained by the
otelConfig
instance to make sure traces from the currentTracerProvider
are being used.