Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to registry.k8s.io in yaml files in prometheus example #870

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

DiptoChakrabarty
Copy link
Contributor

The main Kubernetes container registry is now defaulted to registry.k8s.io. See: https://kubernetes.io/blog/2022/11/28/registry-k8s-io-faster-cheaper-ga/.
Switching to the new registry for the yaml files

@thschue thschue changed the title switch to registry.k8s.io in yaml files feat: switch to registry.k8s.io in yaml files in prometheus example Feb 20, 2023
…eptn#870

Signed-off-by: DiptoChakrabarty <diptochuck123@gmail.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #870 (6910261) into main (6a7b0c1) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   58.63%   58.55%   -0.08%     
==========================================
  Files          97       97              
  Lines        7552     7552              
==========================================
- Hits         4428     4422       -6     
- Misses       2934     2938       +4     
- Partials      190      192       +2     
Impacted Files Coverage Δ
...ptnworkloadinstance/reconcile_prepostdeployment.go 81.81% <0.00%> (-9.10%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 81.16% <0.00%> (-1.35%) ⬇️
Flag Coverage Δ
component-tests 41.65% <ø> (-0.14%) ⬇️
keptn-lifecycle-operator 54.67% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title feat: switch to registry.k8s.io in yaml files in prometheus example chore: switch to registry.k8s.io in yaml files in prometheus example Feb 20, 2023
@mowies mowies merged commit 909a1d6 into keptn:main Feb 20, 2023
@keptn-bot keptn-bot mentioned this pull request Feb 20, 2023
RealAnna pushed a commit that referenced this pull request Feb 22, 2023
RealAnna pushed a commit that referenced this pull request Feb 23, 2023
Amishakumari544 pushed a commit to Amishakumari544/lifecycle-toolkit that referenced this pull request Feb 27, 2023
…eptn#870)

Signed-off-by: Amishakumari544 <amishakumari544@gmail.com>
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants