Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): support Argo Rollout resources #879

Merged
merged 9 commits into from
Apr 5, 2023

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Feb 20, 2023

fixes: #856

This PR:

  • Enables the support of (Argo) Rollout resources as possible workloads
  • Makes it possible to use Pre- and Post-Deployment Tasks with Rollouts

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #879 (0352c29) into main (2c62593) will decrease coverage by 0.27%.
The diff coverage is 6.25%.

❗ Current head 0352c29 differs from pull request most recent head 55fcbbe. Consider uploading reports for the commit 55fcbbe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   59.15%   58.88%   -0.27%     
==========================================
  Files         128      126       -2     
  Lines       10035    10038       +3     
==========================================
- Hits         5936     5911      -25     
- Misses       3884     3907      +23     
- Partials      215      220       +5     
Impacted Files Coverage Δ
...lers/lifecycle/keptnworkloadinstance/controller.go 81.16% <ø> (-1.80%) ⬇️
...keptnworkloadinstance/reconcile_deploymentstate.go 72.22% <0.00%> (-13.03%) ⬇️
...rator/webhooks/pod_mutator/pod_mutating_webhook.go 35.48% <20.00%> (-0.36%) ⬇️

... and 7 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.00% <0.00%> (-1.84%) ⬇️
lifecycle-operator 78.31% <6.25%> (-0.17%) ⬇️
metrics-operator 77.35% <ø> (-0.23%) ⬇️
scheduler 21.17% <ø> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@thschue thschue force-pushed the feat/argo_rollouts_support branch 2 times, most recently from 28b3890 to fa7caf2 Compare March 2, 2023 07:41
@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 55fcbbe
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/642d06d43a6da80008c83a70
😎 Deploy Preview https://deploy-preview-879--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thschue thschue force-pushed the feat/argo_rollouts_support branch 2 times, most recently from c879f66 to e0596a7 Compare March 7, 2023 13:12
Thomas Schuetz and others added 8 commits March 27, 2023 08:16
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Thomas Schuetz <38893055+thschue@users.noreply.github.com>
bacherfl
bacherfl previously approved these changes Mar 27, 2023
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@bacherfl bacherfl merged commit c2b0fa3 into keptn:main Apr 5, 2023
@keptn-bot keptn-bot mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Argo Rollout Resources
3 participants