Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels and annotations to Job Pods #885

Closed
darkgordon opened this issue Feb 20, 2023 · 1 comment · Fixed by #1283
Closed

Add labels and annotations to Job Pods #885

darkgordon opened this issue Feb 20, 2023 · 1 comment · Fixed by #1283
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@darkgordon
Copy link

Hello keptn community, hope you are doing great,

I would like a new feature in keptn lifecycle toolkit, this feature is about adding label and annotations in KeptnTaskDefinition yaml to the job pods that are executed when deploying an precheck or postcheck.

This could be helpful to identify the pods executed by labels or by disabling the istio sidecar if you are executing a pod that is inside a labeled istio namespace.

Thank you very much

@thisthat thisthat added the enhancement New feature or request label Mar 22, 2023
@thisthat
Copy link
Member

Hey @darkgordon, that a very good idea 👍
We could have a label & annotation section in the KeptnTaskDefinition CRD

@thisthat thisthat added the status: ready-for-refinement Issue is relevant for the next backlog refinment label Mar 22, 2023
@thisthat thisthat added this to the 0.8 milestone Mar 22, 2023
@mowies mowies changed the title [New Toolkit feature] Add labels and annotations to Job Pods Add labels and annotations to Job Pods Mar 28, 2023
@thisthat thisthat removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Mar 28, 2023
@odubajDT odubajDT self-assigned this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants