Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix golangci-lint errors #905

Merged
merged 4 commits into from
Feb 27, 2023
Merged

chore: fix golangci-lint errors #905

merged 4 commits into from
Feb 27, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Feb 23, 2023

This PR

  • fixes all currently open linter errors from golangci-lint
    • gci
    • unused variables
    • makes kubebuilder comment style consistent

Notes

Changes are nicely split into separate commits with good descriptions for easy review

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #905 (8c95d70) into main (7b182fa) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #905   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files          97       97           
  Lines        7552     7552           
=======================================
  Hits         4426     4426           
  Misses       2935     2935           
  Partials      191      191           
Impacted Files Coverage Δ
operator/apis/lifecycle/v1alpha1/keptnapp_types.go 91.66% <ø> (ø)
...r/apis/lifecycle/v1alpha1/keptnappversion_types.go 97.10% <ø> (ø)
...r/apis/lifecycle/v1alpha1/keptnevaluation_types.go 96.92% <ø> (ø)
...ecycle/v1alpha1/keptnevaluationdefinition_types.go 100.00% <ø> (ø)
...ifecycle/v1alpha1/keptnevaluationprovider_types.go 100.00% <ø> (ø)
...perator/apis/lifecycle/v1alpha1/keptntask_types.go 97.14% <ø> (ø)
...is/lifecycle/v1alpha1/keptntaskdefinition_types.go 100.00% <ø> (ø)
...tor/apis/lifecycle/v1alpha1/keptnworkload_types.go 92.00% <ø> (ø)
.../lifecycle/v1alpha1/keptnworkloadinstance_types.go 90.76% <ø> (ø)
operator/apis/lifecycle/v1alpha2/keptnapp_types.go 93.33% <ø> (ø)
... and 18 more
Flag Coverage Δ
component-tests 42.20% <100.00%> (ø)
keptn-lifecycle-operator 54.67% <100.00%> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
…nter errors

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
RealAnna
RealAnna previously approved these changes Feb 23, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies requested a review from RealAnna February 23, 2023 13:28
@mowies mowies merged commit a133fdd into keptn:main Feb 27, 2023
@mowies mowies deleted the linter-fixes branch February 27, 2023 08:12
@keptn-bot keptn-bot mentioned this pull request Feb 27, 2023
Amishakumari544 pushed a commit to Amishakumari544/lifecycle-toolkit that referenced this pull request Feb 27, 2023
Signed-off-by: Amishakumari544 <amishakumari544@gmail.com>
aepfli pushed a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 1, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants