-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix golangci-lint errors #905
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
=======================================
Coverage 58.60% 58.60%
=======================================
Files 97 97
Lines 7552 7552
=======================================
Hits 4426 4426
Misses 2935 2935
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
…nter errors Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
requested review from
thisthat,
thschue,
bacherfl and
RealAnna
as code owners
February 23, 2023 13:12
RealAnna
previously approved these changes
Feb 23, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
RealAnna
approved these changes
Feb 23, 2023
bacherfl
approved these changes
Feb 24, 2023
Merged
Amishakumari544
pushed a commit
to Amishakumari544/lifecycle-toolkit
that referenced
this pull request
Feb 27, 2023
Signed-off-by: Amishakumari544 <amishakumari544@gmail.com>
aepfli
pushed a commit
to aepfli/lifecycle-toolkit
that referenced
this pull request
Mar 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
Changes are nicely split into separate commits with good descriptions for easy review