Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong link in the local-setup #916

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix: wrong link in the local-setup #916

merged 3 commits into from
Mar 2, 2023

Conversation

Amishakumari544
Copy link
Contributor

This PR fixes #914

@Amishakumari544
fix: wrong link in the local-setup
a42b8d6 
Signed-off-by: Amishakumari544 <amishakumari544@gmail.com>
@Amishakumari544 Amishakumari544 marked this pull request as draft February 27, 2023 13:03
@Amishakumari544 Amishakumari544 marked this pull request as ready for review February 27, 2023 14:49
thisthat
thisthat previously approved these changes Feb 27, 2023
View reviewed changes
mowies
mowies reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please fix the markdown errors :)

@Amishakumari544
Merge branch 'keptn:main' into update_link
fa6577d
@Amishakumari544
fixed markdownlint error
17e851a 
Signed-off-by: Amishakumari544 <amishakumari544@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Amishakumari544
Copy link
Contributor Author

LGTM but please fix the markdown errors :)

I hope it's working fine now :) @mowies

mowies
mowies approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aepfli aepfli added the documentation Improvements or additions to documentation label Mar 1, 2023
thschue
thschue approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit de89309 into keptn:main Mar 2, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 2, 2023
Merged
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies approved these changes

@aepfli aepfli aepfli approved these changes

@thschue thschue thschue approved these changes

@thisthat thisthat thisthat left review comments

@bacherfl bacherfl Awaiting requested review from bacherfl

@StackScribe StackScribe Awaiting requested review from StackScribe

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong link in the local-setup
5 participants
@Amishakumari544 @thisthat @mowies @aepfli @thschue