fix(metrics-operator): use correct port for serving metrics api #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
==========================================
+ Coverage 57.43% 57.50% +0.06%
==========================================
Files 119 119
Lines 9913 9914 +1
==========================================
+ Hits 5694 5701 +7
+ Misses 4019 4015 -4
+ Partials 200 198 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
toddbaert
reviewed
Mar 2, 2023
toddbaert
previously approved these changes
Mar 2, 2023
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
bacherfl
force-pushed
the
fix/metrics-api-port
branch
from
fadfea1
to
0828b48
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Mar 6, 2023
Merged
thschue
pushed a commit
to thschue/lifecycle-controller
that referenced
this pull request
Mar 7, 2023
…n#954) Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #823
This PR fixes the setup of the K8s service and deployment to be able to access the metrics API endpoint