docs: added more detailed explanation of how to make use of secrets in KeptnTasks #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n KeptnTasks Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
toddbaert
reviewed
Mar 2, 2023
thisthat
approved these changes
Mar 2, 2023
Merged
StackScribe
reviewed
Mar 2, 2023
| Here, the `secret` value is the K8s secret name that will be mounted into the runtime and made available to the function | ||
| via the environment variable `SECURE_DATA`. | ||
|
|
||
| Here, the `secret` value is the name of the K8s secret containing a field with the key `SECURE_DATA`. |
There was a problem hiding this comment.
Are suggestions deliberately disabled here?
I think Kubernetess should be spelled out here rather than K8s
StackScribe
reviewed
Mar 2, 2023
| via the environment variable `SECURE_DATA`. | ||
|
|
||
| Here, the `secret` value is the name of the K8s secret containing a field with the key `SECURE_DATA`. | ||
| The value of that field will then be available to the functions runtime via an environment variable called `SECURE_DATA`. |
There was a problem hiding this comment.
"The value of that field is then available..."
"...to the function runtime..." or "to the functions's runtime" or "to the functions at runtime" -- not sure what is best but this syntax isn't good.
StackScribe
reviewed
Mar 2, 2023
thschue
pushed a commit
to thschue/lifecycle-controller
that referenced
this pull request
Mar 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #588