Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm chart generation fixes #977

Merged
merged 2 commits into from
Mar 8, 2023
Merged

fix: helm chart generation fixes #977

merged 2 commits into from
Mar 8, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Mar 6, 2023

This PR

  • sets the registry correctly to the scarf one for released helm charts
  • uses better branch naming for the charts repo PRs so that ehy are overwritten with pushes to keptn/klt main branch

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit a7542bc
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6405bda219393e0008dcd19c
😎 Deploy Preview https://deploy-preview-977--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #977 (a7542bc) into main (82488ec) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
+ Coverage   57.45%   57.50%   +0.04%     
==========================================
  Files         119      119              
  Lines        9913     9914       +1     
==========================================
+ Hits         5696     5701       +5     
+ Misses       4018     4015       -3     
+ Partials      199      198       -1     
Impacted Files Coverage Δ
metrics-operator/pkg/metrics/server.go 68.80% <0.00%> (+0.25%) ⬆️
...lers/lifecycle/keptnworkloadinstance/controller.go 82.95% <0.00%> (+1.79%) ⬆️
Flag Coverage Δ
certificate-operator 64.15% <ø> (?)
component-tests 50.99% <ø> (+0.82%) ⬆️
klt-cert-manager ?
lifecycle-operator 53.63% <ø> (?)
metrics-operator 62.98% <ø> (+0.03%) ⬆️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title fix: Helm chart fixes fix: helm chart generation fixes Mar 8, 2023
@mowies mowies marked this pull request as ready for review March 8, 2023 12:30
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mowies mowies merged commit 85e9d0e into keptn:main Mar 8, 2023
@mowies mowies deleted the helm-fixes branch March 8, 2023 12:54
@keptn-bot keptn-bot mentioned this pull request Mar 8, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants