Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Conflict #63

Open
ker0olos opened this issue Feb 18, 2023 · 0 comments
Open

Media Conflict #63

ker0olos opened this issue Feb 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ker0olos
Copy link
Owner

ker0olos commented Feb 18, 2023

Character search shows the default media of the character;

But if the character exists (found in gacha by a user) their mediaId is saved to the database and no longer up to the pack's metadata, only search.ts ignores that mediaId metadata for performance sake since querying mediaId to resolve it and get its title is extra steps that will further slowdown the search.

This will cause an issue if a pack updates its data to change the character default media, there will be a conflict between the character media on the search and the character media on /collection and /party and anything else that query the character from the database and uses the response mediaId

@ker0olos ker0olos added the bug Something isn't working label Feb 18, 2023
@ker0olos ker0olos added this to the Backlog milestone Feb 18, 2023
@ker0olos ker0olos modified the milestone: Backlog Mar 8, 2023
@ker0olos ker0olos removed this from the Backlog milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant