Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in docs #1618

Merged
merged 2 commits into from Aug 27, 2021
Merged

Fix broken link in docs #1618

merged 2 commits into from Aug 27, 2021

Conversation

htbkoo
Copy link
Contributor

@htbkoo htbkoo commented Aug 22, 2021

Which issue(s) does this Pull Request fix?

N/A
(This is a very simple fix for the documentation so I had not raised the corresponding issue - please let me know if I should raise that first)

Details of the Pull Request

Updated docs/py/structured_data_regression.py by fixing the link to the California housing dataset hosted on scikit-learn as the current link is no longer accessible

Updated `docs/py/structured_data_regression.py` by fixing the link to the `California housing dataset` hosted on `scikit-learn` as the current link is no longer accessible
@htbkoo
Copy link
Contributor Author

htbkoo commented Aug 22, 2021

Hi Keras team,

First of all, thanks a lot for your efforts in creating / maintain this fantastic library!

FYI, this is my very first PR created at this repo so please do let me know if there is anything wrong with this PR and I would try my best to fix that!

Thanks!

@htbkoo
Copy link
Contributor Author

htbkoo commented Aug 22, 2021

FYI I had tried to do a very simple quick search at the repo and apparently these 2 places are the only references to the example data sets hosted on scikit-learn.org

Copy link
Member

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #1618 (86f82ca) into master (e503c51) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1618   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        51           
  Lines         3339      3339           
=========================================
  Hits          3339      3339           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e503c51...86f82ca. Read the comment docs.

@haifeng-jin haifeng-jin merged commit d9f804e into keras-team:master Aug 27, 2021
@htbkoo htbkoo deleted the patch-1 branch August 28, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants