Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs found and fixed by api-test #762

Merged
merged 18 commits into from
Sep 17, 2019
Merged

Conversation

Davidsirui
Copy link
Contributor

Which issue(s) does this Pull Request fix?

resolves #000

Pull Request Status

Details of the Pull Request

@haifeng-jin
Copy link
Collaborator

@Davidsirui Do we have to use float32 instead of float64? I think for all the other preprocessors requires float64.

@Davidsirui
Copy link
Contributor Author

Davidsirui commented Sep 6, 2019 via email

@keras-team keras-team deleted a comment Sep 7, 2019
@keras-team keras-team deleted a comment Sep 13, 2019
@haifeng-jin haifeng-jin changed the base branch from master to feature_engineering September 15, 2019 18:56
@haifeng-jin haifeng-jin changed the base branch from feature_engineering to master September 15, 2019 18:56
@haifeng-jin haifeng-jin changed the base branch from master to feature_engineering September 15, 2019 19:06
Copy link
Collaborator

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to change everything to float64 instead of float32?

@@ -0,0 +1 @@
{"execution_id": "0", "trial_id": "153a231fe9cc59e45a35abb42c2b5333", "max_epochs": 1, "max_steps": null, "per_epoch_metrics": {"names": ["accuracy"], "directions": {"accuracy": "max"}, "metrics_history": {"accuracy": []}}, "per_batch_metrics": {"names": ["accuracy", "batch", "size", "loss"], "directions": {"accuracy": "max", "batch": "min", "size": "min", "loss": "min"}, "metrics_history": {"accuracy": [0.0625, 0.109375, 0.1354166716337204, 0.140625, 0.11874999850988388, 0.1041666641831398, 0.1116071417927742, 0.1171875, 0.1111111119389534, 0.109375, 0.10511363297700882, 0.0989583358168602, 0.09375, 0.0959821417927742, 0.10208333283662796, 0.09765625, 0.10110294073820114, 0.0954861119389534, 0.09703947603702545, 0.09687499701976776, 0.1011904776096344, 0.09943182021379471, 0.0991847813129425, 0.09765625, 0.09875000268220901, 0.09735576808452606, 0.0972222238779068, 0.0970982164144516, 0.09590516984462738, 0.09687499701976776, 0.09677419066429138, 0.09765625, 0.09943182021379471, 0.09834558516740799, 0.09910714626312256, 0.0980902761220932, 0.09797297418117523, 0.09703947603702545, 0.09455128014087677, 0.09296874701976776, 0.09222561120986938, 0.0900297611951828, 0.09375, 0.09446022659540176, 0.09305555373430252], "batch": [0.0, 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0, 10.0, 11.0, 12.0, 13.0, 14.0, 15.0, 16.0, 17.0, 18.0, 19.0, 20.0, 21.0, 22.0, 23.0, 24.0, 25.0, 26.0, 27.0, 28.0, 29.0, 30.0, 31.0, 32.0, 33.0, 34.0, 35.0, 36.0, 37.0, 38.0, 39.0, 40.0, 41.0, 42.0, 43.0, 44.0], "size": [32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0, 32.0], "loss": [NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN]}}, "epochs_seen": 0, "best_checkpoint": null, "training_complete": false, "start_time": 1567224312, "base_directory": ".\\auto_model\\trial_153a231fe9cc59e45a35abb42c2b5333", "eta": 169}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files should be deleted.

@haifeng-jin haifeng-jin merged commit b29ccf5 into feature_engineering Sep 17, 2019
@haifeng-jin haifeng-jin deleted the bugs_from_api_test branch September 17, 2019 19:50
haifeng-jin pushed a commit that referenced this pull request Sep 24, 2019
* structured data column type detection

* Igbm

* lgbm

* fix travis-ci issue

* temp commit

* weights

* modified the preprocessors for get set weights config

* typo

* lgbm

* Update preprocessor.py

* clear weights and docstrings

* d

* typo

* b

* put clear and save preprocessors in on_trial_end

* Update setup.py

* Update head.py

* b

* Update preprocessor.py

* fixing bug of not clearing weights for first build

* implement feature engineering

* doc

* Update preprocessor.py

* doc

* Update block.py

* Update preprocessor.py

* Update test_preprocessor.py

* Update hyperblock.py

* Update hyperblock.py

* block

* implement feature engineering

* regressor

* Update preprocessor.py

* Update test_preprocessor.py

* hyper

* extract the base class out.

* doc

* doc

* implement feature engineering

* suppress warning for lightgbm

* refining docstrings

* delete redundant import

* bug fix

* potential bug fix

* bug fix

* bug fix

* add new import to __init__.py

* Update auto_model.py

* bug fix

* bug fix of transform that has test data with new categories

* add structured data regressor test

* add transform new data test

* add structured data task detection to meta_model

* fix typo

* structured data blocks

* fixing bugs

* bug fix

* style change

* bug fix

* docstrings

* extract structured_data() to common.py

* extract structured_data() to common.py

* variable and function name changed

* fix typo

* fix typo

* fix typo

* bugs found and fixed by api-test (#762)

* bug tested by api

* bug

* Update io_api.py

* bug

* bug

* delete files

* bug fix

* bug fix

* integration tests

* bug

* bugs

* bugs

* bug_fix

* bug

* Create test_functional_api.py

* node bound to transform data

* bug fix

* bug fix

* bug fix

* style fix

* bug fix

* Update task_api.py

* Csv (#774)

* support structured data from csv

* Fix copypasta'd default names for AutoModels (#773)

* support data from csv files

* support structured data from csv

* Fix copypasta'd default names for AutoModels (#773)

* support data from csv files

* rebase

* bug fix

* complete StructuredDataInput.fit and reduce duplication

* delete print

* split graph hyper model and hyper built

* graph compile

* set input node for fe by compile

* separate structured blocks from heads

* addressing comments

* bug fix

* Partial column types (#776)

* support structured data from csv

* Fix copypasta'd default names for AutoModels (#773)

* support data from csv files

* support structured data from csv

* Fix copypasta'd default names for AutoModels (#773)

* support data from csv files

* rebase

* bug fix

* complete StructuredDataInput.fit and reduce duplication

* delete print

* support partial column_types

* bug fix

* addressing comments

* fix typo

* docstrings

* docstrings

* bug fix

* docstrings

* move postprocess to heads

* style changes, tests added

* docstring

* docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants