Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port zero-dce example to keras-core #486

Merged
merged 4 commits into from
Jul 16, 2023
Merged

Port zero-dce example to keras-core #486

merged 4 commits into from
Jul 16, 2023

Conversation

soumik12345
Copy link
Contributor

Port the keras-io example Zero-DCE for low-light image enhancement to keras_core.

tf.keras backwards compatibility check: #485
Colab Notebook: https://colab.research.google.com/drive/1GuumdRuh9wy_Eo_zzORFfG2iX8gGG58a?usp=sharing

@soumik12345 soumik12345 mentioned this pull request Jul 15, 2023
Open
fchollet
fchollet reviewed Jul 15, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

examples/keras_io/tensorflow/vision/zero_dce.py Outdated Show resolved Hide resolved
examples/keras_io/tensorflow/vision/zero_dce.py Show resolved Hide resolved
@soumik12345 soumik12345 mentioned this pull request Jul 15, 2023
Closed
fchollet
fchollet reviewed Jul 15, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you confirm it's running? We're not running it on CI so you'll want to make sure it runs on your side before we merge.

@soumik12345
Copy link
Contributor Author

Thanks! Do you confirm it's running? We're not running it on CI so you'll want to make sure it runs on your side before we merge.

It's running perfectly, here's the colab for reference.

fchollet
fchollet approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fchollet fchollet merged commit 1f6b69a into keras-team:main Jul 16, 2023
1 check passed
@soumik12345 soumik12345 deleted the example/zero-dce branch July 23, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soumik12345 @fchollet