Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yolov8 detector] Fix example in docstring #2082

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

cosmo3769
Copy link
Contributor

What does this PR do?

  • Fixed typo:
    -- yolo_v8_m_coco to yolo_v8_m_backbone_coco
    -- fpn_depth=2. to fpn_depth=2
  • Fixed model.fit
    -- Converted labels to labels_tensor.
    -- model.fit(images, labels) to model.fit(images, labels_tensor)

Who can review?

@ianstenbit @jbischof

Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Looks good -- just one little tweak

@@ -362,13 +362,24 @@ class YOLOV8Detector(Task):
],
"classes": [[1, 1, 1]],
}

# Convert labels to tensors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, why don't we just add tf.constant calls above on lines 356+363?

Copy link
Contributor Author

@cosmo3769 cosmo3769 Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah true, fixed it. Thank you.

Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ianstenbit ianstenbit merged commit 47e6f86 into keras-team:master Sep 21, 2023
6 of 9 checks passed
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
* fix example in docstring

* review comments
yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this pull request Feb 8, 2024
* fix example in docstring

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants