Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export task models as both models.task.Model and models.Model #2093

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

ianstenbit
Copy link
Contributor

Right now we have a bit of inconsistency here, and this standardizes our task model exports.

@jbischof
Copy link
Contributor

jbischof commented Oct 2, 2023

Why is this needed? Should we include ImageClassifier?

@ianstenbit
Copy link
Contributor Author

Why is this needed? Should we include ImageClassifier?

It's not strictly needed, but it's a nice quality of life change IMO which makes the namespacing a bit more accessible.

@ianstenbit
Copy link
Contributor Author

/gcbrun

@ianstenbit ianstenbit merged commit 69de849 into keras-team:master Oct 2, 2023
8 of 9 checks passed
@ianstenbit ianstenbit deleted the export-models branch October 2, 2023 22:35
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
…team#2093)

* Export task models as both models.task.Model and models.Model

* Same for ImageClassifier
yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this pull request Feb 8, 2024
…team#2093)

* Export task models as both models.task.Model and models.Model

* Same for ImageClassifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants