Fix the issue (#2102): Add cast to float32 from float16 into Stable D… #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianstenbit
reviewed
Nov 1, 2023
| @@ -235,6 +235,8 @@ def generate_image( | |||
| + unconditional_guidance_scale * (latent - unconditional_latent) | |||
| ) | |||
| a_t, a_prev = alphas[index], alphas_prev[index] | |||
| if latent.dtype == "float16": | |||
There was a problem hiding this comment.
I think we should be able to unconditionally cast latent to the dtype of latent_prev, e.g. ops.cast(latent, latent_prev.dtype).
Is there a reason that won't work?
There was a problem hiding this comment.
@ianstenbit
Thank you very much for your comment.
I think you are right!
I will try your advice and modify the code!!
There was a problem hiding this comment.
@ianstenbit
I tried your suggestion and modified the code!
Thank you!!
If there is no problem, please approve my modification.
…o Stable Diffusion
ghost
force-pushed
the
add_cast_to_fp32_from_fp16_into_stable_diffusion
branch
from
cc214e6
to
3c2f897
Compare
ianstenbit
approved these changes
Nov 2, 2023
|
/gcbrun |
ghost
pushed a commit
to y-vectorfield/keras-cv
that referenced
this pull request
Nov 16, 2023
…o Stable Diffusion (keras-team#2124)
yuvraj-wale
pushed a commit
to yuvraj-wale/keras-cv
that referenced
this pull request
Feb 8, 2024
…o Stable Diffusion (keras-team#2124)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixed Issue #2102 (InvalidArgumentError occurred when I implemeted image generation using mixed float16) .
Fixes # (issue)
#2102
Who can review?
@ianstenbit
@jbischof
Someone who know this problem.