DQN example huber loss and typo, issue #82 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharrezt
changed the title
fchollet
reviewed
Jun 9, 2020
| @@ -209,7 +209,7 @@ | |||
| q_action = tf.reduce_sum(tf.multiply(q_values, masks), axis=1) | |||
| # Calculate loss between new Q-value and old Q-value | |||
| # Clip the deltas using huber loss for stability | |||
| loss = keras.losses.huber(updated_q_values, q_action) | |||
| loss = tf.compat.v1.losses.huber_loss(updated_q_values, q_action) | |||
There was a problem hiding this comment.
This should be tf.reduce_mean(keras.losses.huber(...)), see https://keras.io/api/losses/regression_losses/#huber-function
Or alternatively
loss_fn = Huber() # Outside the loop
loss = loss_fn(...)
There was a problem hiding this comment.
Thanks for the correction, since keras.losses.huber was added in tf-nightly, I am adding the command to install it in the colab.
There was a problem hiding this comment.
Please remove the commands, the file already explicitly mentions that you need to install tf-nightly.
There was a problem hiding this comment.
Those commands were removed! thanks for pointing that out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #82
Adding baselines package need to run the notebook,
Correcting small typo
Changing huber loss function for tf2