New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ocr example #91
Add ocr example #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! This will be a great new example.
Thanks @fchollet for the review. I will make the necessary changes |
@fchollet I have made all the changes except for removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the update.
Note that the motivation for using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Please address the last 2 comments and you can add the autogenerated files.
Thanks for the review. I have made all the changes.
Totally agree with you. My only concern here is that for some APIs, we haven't provided clear cut code examples for their usage (for example CTC related functionalities). So, both things are required: removing the backend and improving the documentation in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the great contribution!
Thanks for the review |
No description provided.